Re: toml-ts-mode: first draft

[Jostein Kjønigsen]

On 12.12.2022 00:01, Yuan Fu wrote:

Looks great!

+  (unless (treesit-ready-p 'toml)
+    (error "Tree-sitter for TOML isn't avilable”))

Treesit-ready-p already raises a warning when something goes wrong. So you want to either pass the QUIET argument or let it do the barking ;-)

Yuan

Hey everyone. A quick update.

I've updated the code to follow the above-mentioned (when (treesit-ready-p ...)) convention.

Bigger news perhaps is that I've also updated it to support imenu.

The imenu-implementation is limited to tables/sections/array-elements only, and has no accessor for direct values. That said it still works pretty good and the code should be fully understandable.

Said simply, the patch attached to this email contains all fixes and features requested by everyone so far.

I consider it more than good enough for everyday use at this point.

I'm obviously biased, but I have to say this version fares quite favourable when doing an objective comparison to toml-mode as found in MELPA:

• better and more consistent fontification
• better support for various quoting formats
• better support for dotted values
• better support for inline tables
• it highlights syntax-errors
  
• it actually has imenu support (limited to headers/tables only, now direct value access)

Pretty much every obvious bug I see in the MELPA-version is fixed in this one.

So... Any other requests I should look into before we start considering merging this? :)

--
Jostein

0002-Introduce-support-for-TOML-config-format.patch
Description: Text Data