Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot

[Michael Albinus]

Stefan Kangas <stefankangas@gmail.com> writes:

Hi Stefan,

>> As for the :expensive, what do you think makes a test
>> expensive.  The longest-running tests in my machine
>> take less than 3 seconds.  But I'm not running the
>> jtdls one (and I seem to remember that takes a bit
>> more time).  So here, too, fell free to add :expensive
>> tags to those tests.
>
> I'd basically consider any test over half a second or a second or so as
> a candidate for being marked as :expensive.  But we should do it
> judiciously, of course.  (And even better if we can find a way to make
> slow tests faster.)

That's a very restrictive rule. IIRC, we've discussed this a while ago,
and a recommendation was to regard tests lasting more than 10 seconds
being expensive. But I might remeber this wrong.

>    passed  12/50  eglot--tramp-test (2.158451 sec)

All eglot Tramp tests could be regarded as :expensive by default, I
guess.

Best regards, Michael.