[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: toml-ts-mode: first draft
From: |
Eli Zaretskii |
Subject: |
Re: toml-ts-mode: first draft |
Date: |
Tue, 13 Dec 2022 15:20:16 +0200 |
> From: Rudolf Schlatte <rudi@constantly.at>
> Date: Tue, 13 Dec 2022 11:45:42 +0100
>
> Yuan Fu <casouri@gmail.com> writes:
>
> >
> > + (unless (treesit-ready-p 'toml)
> > + (error "Tree-sitter for TOML isn't avilable”))
> >
> > Treesit-ready-p already raises a warning when something goes wrong. So
> > you want to either pass the QUIET argument or let it do the barking
> > ;-)
>
> I'd expect predicates (functions ending -p) to return T or NIL only and
> not have side effects.
Did you read the doc string of this function? I think it explains why
this predicate can sometimes emit a warning and sometimes not. It has
more than one modus operandi.
- Re: toml-ts-mode (code-review done), (continued)
- Re: toml-ts-mode (code-review done), Theodor Thornhill, 2022/12/14
- Re: toml-ts-mode (code-review done), Yuan Fu, 2022/12/14
- Re: toml-ts-mode (code-review done), Jostein Kjønigsen, 2022/12/14
- Re: toml-ts-mode (code-review done), Randy Taylor, 2022/12/14
- Re: toml-ts-mode (code-review done), Jostein Kjønigsen, 2022/12/15
- Re: toml-ts-mode (code-review done), Theodor Thornhill, 2022/12/15
- Re: toml-ts-mode (code-review done), Jostein Kjønigsen, 2022/12/15
- Re: toml-ts-mode (code-review done), Eli Zaretskii, 2022/12/15
- Re: toml-ts-mode (code-review done), Jostein Kjønigsen, 2022/12/15
- Re: toml-ts-mode: first draft, Rudolf Schlatte, 2022/12/13
- Re: toml-ts-mode: first draft,
Eli Zaretskii <=
- Re: toml-ts-mode: first draft, Rudi Schlatte, 2022/12/13