emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot


From: Michael Albinus
Subject: Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot
Date: Tue, 13 Dec 2022 20:10:37 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

João Távora <joaotavora@gmail.com> writes:

Hi João,

>> Do you really need this?
>
> Flymake tells me there are 4 compilation warnings if I don't:
>
>  1243   9 warning  e-f-b-c  Unused lexical variable
> `tramp-remote-path'
>  1243  56 warning  e-f-b-c  reference to free variable
> ‘tramp-remote-path’
>  1244   9 warning  e-f-b-c  Unused lexical variable
> `tramp-histfile-override'
>  1245   9 warning  e-f-b-c  Unused lexical variable `tramp-methods'
>
> Here, the flymake backend 'e-f-b-c' (elisp-flymake-byte-compile)
> compiles with Emacs -Q
> and no specially relevant load path in these cases.

I've fixed this in eglot-tests.el. I've also adapted the two tests wrt
Tramp. Pushed to the emacs-29 branch.

FTR, I'm suprised about the names of the test cases. Would it be
possible to give them a unique prefix, like `eglot-test-'?

> João

Best regards, Michael.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]