emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: toml-ts-mode (code-review done)


From: Yuan Fu
Subject: Re: toml-ts-mode (code-review done)
Date: Wed, 14 Dec 2022 12:37:18 -0800


> On Dec 14, 2022, at 11:02 AM, Theodor Thornhill <theo@thornhill.no> wrote:
> 
> 
> 
> On 14 December 2022 19:53:25 CET, "Jostein Kjønigsen" 
> <jostein@secure.kjonigsen.net> wrote:
>> On 14.12.2022 14:24, Randy Taylor wrote:
>>> 
>>> On Wednesday, December 14th, 2022 at 03:40, Jostein Kjønigsen 
>>> <jostein@secure.kjonigsen.net> wrote:
>>> Nice catch. Fixed.
>>>> 
>>>> Attached is a new revision. Final revision? Is this good for merging now? 
>>>> :)
>>>> 
>>>> --
>>>> 
>>>> Jostein
>>>> 
>>> Looks good to me!
>>> 
>> Great! Thanks for
>> 
>> So what's the next move from here on? Are there any other things which needs 
>> to be completed before this can be merged?
>> 
>> I'm asking since this is my first full "original" submissions, which isn't a 
>> patch to an existing package/module. :)
>> 
>> --
>> Jostein
> 
> Imo it's only missing a push :)
> 
> Theo

I applied and pushed it. Great work, folks!

Yuan


reply via email to

[Prev in Thread] Current Thread [Next in Thread]