Re: emacs-29 9c0d7bb73b 2/2: Add automated tests for Eglot

[Michael Albinus]

Stefan Kangas <stefankangas@gmail.com> writes:

Hi Stefan,

> More conventions are in use than that, and I couldn't confidently say
> which is the preferred one.  Probably it's not that important, as long
> as every file consistently uses one or the other.

Yes.

> FWIW, I don't see any major benefit to having "-test" in the test name,
> as the fact that it's a test is immediately obvious in all contexts
> where you see them.  So it mostly just makes the test names longer.

For me, who doesn't know the eglot codebase, it is helpful to see,
whether a Lisp object belongs to eglot or eglot-tests.

Prior my changes, there were even the defun `eglot-lsp-abiding-column'
and the ert-deftest `eglot-lsp-abiding-column'. Terrible!

Best regards, Michael.