Re: Add four new Modus themes to Emacs?

[Philip Kaludercic]

Protesilaos Stavrou <info@protesilaos.com> writes:

> Hello everyone,

Hi,

> I am developing version-4 of the modus-themes.  Part of this endeavour
> is the creation of four new themes.  Originally, we had 'modus-operandi'
> (light theme) and 'modus-vivendi' (dark theme).  They are the ones that
> are shipped with Emacs since version 28.
>
> The new themes:

[...]

> All new themes are consistent with the WCAG AAA accessibility standard
> for colour contrast.
>
> Should these four new themes be added to emacs.git when I release
> version-4?  Or should I just update only 'modus-operandi' and
> 'modus-vivendi'?

My main worry is that the default theme options could get too crowded.
Then again, if we want to keep deuteranopia support, the two new
variants will have to be added... (On that topic, I still think that the
approach I suggested earlier this year would be preferable: Instead of a
separate theme or multiple options, we just need to describe the
transformations that maximise the volume of the original colour space
within the boundaries of whatever is permissible for each kind of colour
deficiency).

The alternative is having the base themes in Emacs, and if anyone wants
more then they would have to download the themes from ELPA, right?

> My plan is to finalise version-4 by the end of this month.  It contains
> lots of changes.

This might be a bit late, but I think that you were a bit too quick in
deprecating a lot of the user option, while also dropping backwards
compatibility.  Usually, an option is deprecated and users are given
hints what they have to do in the future, but everything will continue
working for now.  When I recently installed version-4, I noticed that a
number of things changed and I wasn't sure where to look to fix these
issues.  Now of course, this is just a visual theme and nothing about
Emacs breaks functionality-wise, but it would still be nice to have a
shim for now that translates old user options into the new configuration
pattern.