emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Progress for bug#59314 for emacs-29


From: Stefan Monnier
Subject: Re: Progress for bug#59314 for emacs-29
Date: Wed, 21 Dec 2022 00:19:41 -0500
User-agent: Gnus/5.13 (Gnus v5.13)

> +  (when (and (or eudc-server eudc-server-hotlist)
> +             (seq-some #'derived-mode-p eudc-capf-modes)
> +             (let ((mail-abbrev-mode-regexp 
> message-email-recipient-header-regexp))
> +               (mail-abbrev-in-expansion-header-p)))
> +    (setq-local completion-styles '(substring partial-completion))
> +    (eudc-capf--message-expand-name)))

Please don't do that.  `completion-styles` is a user-config, we
shouldn't mess with it.  Instead you should use
`completion-category-defaults` (and use a completion table which returns
an appropriately chosen `category`).  Then users can decide to override
your choice with `completion-category-overrides`.


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]