emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 bbe35c280c: Prevent stale servers when using eglot-extend-t


From: João Távora
Subject: Re: emacs-29 bbe35c280c: Prevent stale servers when using eglot-extend-to-xref
Date: Thu, 22 Dec 2022 15:30:15 +0000

> >     A weak-valued hash-table is not enough to guarantee that a reference
> >     to a zombie server in eglot--servers-by-xrefed-file variable won't
> >     survive long enough to confuse the next call to eglot--current-server
> >     in some buffers.
> [...]
> > +(defvar eglot--servers-by-xrefed-file
> > +  (make-hash-table :test 'equal :weakness 'value))
> Do we still need it to be weak?

Prolly not, if we presume the operations running up to the
new cleanup can't throw.  Probably a fair assumption. 
But better be safe? Does value-weakness in a typically small
hash table hurt GC significantly somehow?  Anyway, feel free
to remove.

João

reply via email to

[Prev in Thread] Current Thread [Next in Thread]