Re: Make failure - progmodes/typescript-ts-mode.elc

[Eli Zaretskii]

> From: Colin Baxter <m43cap@yandex.com>
> Date: Thu, 29 Dec 2022 09:34:36 +0000
> 
> 
> On a fresh git pull I have this 'make' failure:
> 
> --8<---------------cut here---------------start------------->8---
> 
>  ELC      progmodes/typescript-ts-mode.elc
> 
> In toplevel form:
> progmodes/typescript-ts-mode.el:31:2: Error: Symbol’s function definition is 
> void: treesit-query-compile
> Makefile:332: recipe for target 'progmodes/typescript-ts-mode.elc' failed
> make[4]: *** [progmodes/typescript-ts-mode.elc] Error 1
> make[4]: Leaving directory '/home/redknight/git/emacs/lisp'
> Makefile:366: recipe for target 'compile-main' failed
> make[3]: *** [compile-main] Error 2
> make[3]: Leaving directory '/home/redknight/git/emacs/lisp'
> Makefile:533: recipe for target 'lisp' failed
> make[2]: *** [lisp] Error 2
> make[2]: Leaving directory '/home/redknight/git/emacs'
> make[2]: Entering directory '/home/redknight/git/emacs'
> ***
> *** "make all" failed with exit status 2.
> ***
> *** You could try to:
> *** - run "make bootstrap", which might fix the problem
> *** - run "make V=1", which displays the full commands invoked by make,
> ***   to further investigate the problem
> ***
> 
> --8<---------------cut here---------------end--------------->8---
> 
> I have tried both make bootstrap <RET>, and make extraclean <RET>
> followed by make <RET>, but to no avail.
> 
> I am on Linux bluestar 4.9.0-19-686-pae #1 SMP Debian 4.9.320-2
> (2022-06-30) i686 GNU/Linux.

Doesn't happen here.  However, I'm guessing that your build is without
tree-sitter.  Please make a point of using report-emacs-bug, so that
we won't need to guess.

Yuan, this code in js.el:

  (defvar js--treesit-lhs-identifier-query
    (treesit-query-compile 'javascript '((identifier) @id
                                         (property_identifier) @id))
    "Query that captures identifier and query_identifier.")

cannot unconditionally call treesit-query-compile, because it will
fail to load in a build without tree-sitter.  (It also need a
declare-function.)

The above failure is caused because typescript-ts-mode.el requires
js.el.