emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Tree-sitter introduction documentation


From: Eli Zaretskii
Subject: Re: Tree-sitter introduction documentation
Date: Fri, 30 Dec 2022 18:17:37 +0200

> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Yuan Fu <casouri@gmail.com>,  monnier@iro.umontreal.ca,
>   dgutov@yandex.ru,  theophilusx@gmail.com,  emacs-devel@gnu.org
> Date: Fri, 30 Dec 2022 15:54:11 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >           (message "Cloning repository")
> >           ;; git clone xxx --depth 1 --quiet workdir
> >           (treesit--call-process-signal
> >            "git" nil t nil "clone" url "--depth" "1" "--quiet"
> >            workdir)
> >
> > Why "--depth 1"?  This should be a defcustom, and the default should
> > be to clone the full repository, IMO.  Also, what about updating the
> > library when it is already installed, and the Git repository already
> > exists for it?  Or are we going to clone anew each time and them
> > remove the repository? that could make its cloning be slow in some
> > cases.
> 
> I have proposed just downloading a tarball.

That could be a good solution.

But again, we need a broader view and concept on how this kind of
feature should work.  We don't have anything similar to it in Emacs,
AFAIK, so we are in uncharted land here, kind of.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]