[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle firs

From: Juri Linkov
Subject: Re: emacs-29 9ecebcdded: * lisp/simple.el (next-completion): Handle first completion specially.
Date: Sat, 14 Jan 2023 20:57:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)

>>     Eli> Fixed.  It's a clear case of a test that adapted the results to what
>>     Eli> the code produced, not to the desired/expected value.
>> Itʼs fixed, but Iʼll admit that I donʼt understand why:
>>       (should (equal "aa" (get-text-property (point) 'completion--string)))
>>       (next-completion 3)
>>       (should (equal "ac" (get-text-property (point) 'completion--string)))
>>       (previous-completion 2)
>>       (should (equal "aa" (get-text-property (point) 'completion--string)))
>> So we go forward 3 from "aa" to get to "ac", but then to get back to
>> "aa" itʼs back 2?
> Indeed, the test was correct, but the implementation has a bug.

This bug is fixed now.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]