[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'ou

From: Robert Pluim
Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'.
Date: Mon, 16 Jan 2023 16:02:38 +0100

>>>>> On Mon, 16 Jan 2023 16:33:17 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: Juri Linkov <juri@linkov.net>
    >> Date: Mon, 16 Jan 2023 14:57:03 +0100
    >> >>>>> On Wed, 11 Jan 2023 14:37:54 -0500 (EST), Juri Linkov 
<juri@jurta.org> said:
    Juri> branch: emacs-29
    Juri> commit 4a8891a462e41e81a5232810b67d9d85f79bc515
    Juri> Author: Juri Linkov <juri@linkov.net>
    Juri> Commit: Juri Linkov <juri@linkov.net>
    Juri> * etc/NEWS: Mention incompatible changes in 
    Juri> * lisp/outline.el (outline-minor-mode-cycle--bind):
    Juri> Add docstring (bug#60426).
    Juri> (outline-minor-mode-cycle--bind): Default 'map' to
    Juri> 'outline-minor-mode-cycle-map'.
    Juri> (outline-minor-mode-cycle-map): Improve docstring.
    Juri> (outline-minor-mode): Move margin-cycling keys to
    Juri> 'outline-minor-mode-cycle-map'.
    Juri> ---
    >> Juri/Eli, any objection to putting something like the following in
    >> emacs-29? That would make it easier to add heading-specific bindings
    >> in NEWS mode, which Iʼd do in master. It also avoids creating a
    >> separate keymap for each heading.

    Eli> I don't think I understand the problem you are trying to solve, and
    Eli> why this particular solution.  Please tell more.

In outline-mode and modes derived from it, there are various bindings
that work at the start of headings (and in buttons that could be
inserted depending on the value of `outline-minor-mode-use-buttonsʼ),
such as "RET" for `outline-cycle'.

Adding more bindings there is a pain, since the bindings are done
using a separate anonymous keymap on each per-heading overlay, which
means iterating over all the overlays in order to make changes. The
patch I sent changes that to use a named keymap, so only the named
keymap needs to be updated or `setq-local'ʼd before invoking

(and what I really want to do is add 'n' and 'p' into that map, which
improves the speed at which I can proofread NEWS.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]