[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'ou

From: Robert Pluim
Subject: Re: emacs-29 4a8891a462: * etc/NEWS: Mention incompatible changes in 'outline-minor-mode-cycle-map'.
Date: Mon, 16 Jan 2023 18:18:47 +0100

>>>>> On Mon, 16 Jan 2023 18:58:45 +0200, Eli Zaretskii <eliz@gnu.org> said:

    >> From: Robert Pluim <rpluim@gmail.com>
    >> Cc: emacs-devel@gnu.org,  juri@linkov.net
    >> Date: Mon, 16 Jan 2023 16:02:38 +0100
    >> >> Juri/Eli, any objection to putting something like the following in
    >> >> emacs-29? That would make it easier to add heading-specific bindings
    >> >> in NEWS mode, which Iʼd do in master. It also avoids creating a
    >> >> separate keymap for each heading.
    Eli> I don't think I understand the problem you are trying to solve, and
    Eli> why this particular solution.  Please tell more.
    >> In outline-mode and modes derived from it, there are various bindings
    >> that work at the start of headings (and in buttons that could be
    >> inserted depending on the value of `outline-minor-mode-use-buttonsʼ),
    >> such as "RET" for `outline-cycle'.
    >> Adding more bindings there is a pain, since the bindings are done
    >> using a separate anonymous keymap on each per-heading overlay, which
    >> means iterating over all the overlays in order to make changes. The
    >> patch I sent changes that to use a named keymap, so only the named
    >> keymap needs to be updated or `setq-local'ʼd before invoking
    >> `outline-mode'.

    Eli> Ah, okay.  Fine with me if Juri (or someone else) doesn't object.

    >> (and what I really want to do is add 'n' and 'p' into that map, which
    >> improves the speed at which I can proofread NEWS.)

    Eli> On master or emacs-29?

On master. Iʼm assuming adding bindings would not fall under 'bug
fixes only'.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]