Re: [PATCH] em-cmpl: fix completion of command paths

[Jim Porter]

On 1/25/2023 9:03 AM, Stefan Monnier wrote:
> > The use of `completion-table-dynamic' was introduced in 899055e to fix
> > bug#48995. However the following issue remains: when completing a command
> > path, absolute ("/usr/bin/") or relative ("./subdir/"), a space is
> > automatically added at the end.
> > Bypassing `completion-table-dynamic' for filenames containing a directory
> > part fixes the final space bug and does not reintroduce bug#48995.
>
> This looks very good.
> IIUC this fixes a regression w.r.t Emacs-28, so it would be nice to
> install it into `emacs-29`.

I'm not sure about all the details of this bug, but over in bug#60845, 
I'm adding some regression tests for completion in Eshell. It probably 
wouldn't be too hard for someone (possibly me if I have time) to write 
some regression tests for this command path issue too. Then hopefully 
this won't cause problems in the future.