[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames

From: Tom Gillespie
Subject: Re: [PATCH] Fix display-buffer-use-some-window to honor reusable-frames
Date: Sat, 28 Jan 2023 14:04:44 -0500

> A few words about Tom's patch: 'display-buffer-use-some-window' must not
> pop up a new window.  It's doc-string clearly says to "Display BUFFER in
> an existing window."  Please don't ever try to change that.  Also, it
> should not care about 'reusable-frames'.  The latter is about reusing a
> window that already shows BUFFER and other action functions might be
> affected badly if 'display-buffer-use-some-window' tried to handle this
> too.  Finally, 'display-buffer-no-window' has no place in another action
> function.  It is strictly reserved to callers and users.

Thank you for the clarification. I tried to figure out what the right thing
to do was based on the docstrings, but missed a few critical points.

I think the right solution in this context is to not call
'display-buffer-use-some-window' in
'display-buffer-use-least-recent-window' and instead to implement
the behavior inside dbulrw itself.

With regard to the other issues about multiple frames, I was able
to get the behavior I wanted, or rather prevent the behavior I didn't
want by making dbulrw honor a reusable-frames setting so that it
doesn't leak out to other windows. I'm not going to wade into the
question of whether the resolution and tracking of least recently
used is happening correctly, I just need it to stop reusing windows
in other frames.

Will send another patch along.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]