emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: server.el test failures


From: Robert Pluim
Subject: Re: server.el test failures
Date: Wed, 01 Mar 2023 09:22:42 +0100

>>>>> On Tue, 28 Feb 2023 11:41:41 -0800, Jim Porter <jporterbugs@gmail.com> 
>>>>> said:
    Jim> +  ;; When running in a batch session, we can't create a GUI frame.

Itʼs not that we canʼt, itʼs that we shouldnʼt. If we install a SIGIO
handler and run the test with DISPLAY set, a GUI frame appears
briefly.

    Jim> +  (when noninteractive
    Jim> +    (push '(display . nil) parameters))
    Jim> +

I think that might be better off using `alist-get' + `setf' to avoid
having two `display' elements in the parameters.

    Jim>    (let* ((display (cdr (assq 'display parameters)))
    Jim>           (w (cond
    Jim>               ((assq 'terminal parameters)
    Jim> -- 
    Jim> 2.25.1



Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]