[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New branch feature/named-lambdas.

From: Alan Mackenzie
Subject: Re: New branch feature/named-lambdas.
Date: Tue, 18 Jul 2023 11:14:17 +0000

Hello, Philip.

On Mon, Jul 17, 2023 at 21:37:41 +0000, Alan Mackenzie wrote:
> On Mon, Jul 17, 2023 at 19:52:01 +0000, Philip Kaludercic wrote:
> > Alan Mackenzie <acm@muc.de> writes:

[ .... ]

> > > This was achieved by adding an extra defining-symbol field to each of
> > > the three forms of function (interpreted, byte-compiled,
> > > native-compiled).  It is indended that this version of Emacs will
> > > continue to handle functions compiled without this enhancement.

> > I think the idea is nice, but there are a lot of whitespace changes in
> > your commit that make identifying the real changes a bit difficult.

> Yes.  I was instinctively correcting WS mis-alignment as I went along.
> This was a mistake, sorry.

> I've found a way to identify where these WS changes are, involving a git
> diff, and a git diff -b, taking the diff -u between these two outputs,
> then feeding that to grep '^[+-]@@'.  This identifies 10 places where the
> whitespace has changed.  I hope that's all of them, but I'll check.

> I'll go through these tomorrow morning and commit them to
> feature/named-lambdas.  This will have the advantage of making my patch
> file several hundred lines shorter.  ;-)

I've reverted a few whitespace changes (together with an unintentional
deletion of a condition-case in comp.el).

Most of the the WS changes were actually due to semantic changes, e.g. by
enclosing a block of forms in an extra (let ....).

It can help to use the -b flag in git diff (or indeed in diff itself),

    git diff -b master..feature/named-lambdas


> -- 
> Alan Mackenzie (Nuremberg, Germany).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]