Re: [PATCH] notifications: Don't expand-file-name app-icon.

[Eli Zaretskii]

> From: Andrew Tropin <andrew@trop.in>
> Date: Mon, 24 Jul 2023 12:39:06 +0400
> 
> Icon is not always a file name, but can be just an icon name.
> https://specifications.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
> 
> * lisp/notifications.el (notifications-notify): Don't expand-file-name
> app-icon.
> ---
> Otherwise it not possible to send a notification similiar to:
> notify-send -i multimedia-player "I am playing music"
> 
>  lisp/notifications.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/notifications.el b/lisp/notifications.el
> index 984ddbec5e9..c314858d0ae 100644
> --- a/lisp/notifications.el
> +++ b/lisp/notifications.el
> @@ -304,7 +304,7 @@ notifications-notify
>                                         notifications-application-name)
>                             :uint32 (or replaces-id 0)
>                             :string (if app-icon
> -                                       (expand-file-name app-icon)
> +                                          app-icon

Thanks, but won't this break the cases where app-icon _is_ a file
name?