[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] notifications: Don't expand-file-name app-icon.
From: |
Andrew Tropin |
Subject: |
Re: [PATCH] notifications: Don't expand-file-name app-icon. |
Date: |
Tue, 25 Jul 2023 17:51:28 +0400 |
On 2023-07-25 15:51, Eli Zaretskii wrote:
>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: Andrew Tropin <andrew@trop.in>, emacs-devel@gnu.org
>> Date: Tue, 25 Jul 2023 12:43:41 +0200
>>
>> Perhaps we extend the arguments of `notifications-notify'? :app-icon
>> should be either a string (a file name, which is expanded), or a symbol,
>> which denotes one of the Standard Action Icons of the Icon Naming
>> Specification.
>>
>> Your example would read in Lisp then
>>
>> --8<---------------cut here---------------start------------->8---
>> (notifications-notify :title "I am playing music" :app-icon
>> 'multimedia-player)
>> --8<---------------cut here---------------end--------------->8---
>>
>> WDYT?
>
> SGTM, thanks.
Does it make sense to introduce edge-case and differentiate between
strings and symbols? Removing expand-file-name seems to be backward
compatible and simple solution, but if there is some good reason for
symbol/string solution - let me know, I will update the patch.
--
Best regards,
Andrew Tropin
signature.asc
Description: PGP signature
- [PATCH] notifications: Don't expand-file-name app-icon., Andrew Tropin, 2023/07/24
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/24
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon.,
Andrew Tropin <=
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Andrew Tropin, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Michael Albinus, 2023/07/26
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Andrew Tropin, 2023/07/26
Re: [PATCH] notifications: Don't expand-file-name app-icon., Andrew Tropin, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Dmitry Gutov, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Andrew Tropin, 2023/07/25
- Re: [PATCH] notifications: Don't expand-file-name app-icon., Eli Zaretskii, 2023/07/25