Re: [PATCH] notifications: Don't expand-file-name app-icon.

[Eli Zaretskii]

> Date: Tue, 25 Jul 2023 19:48:53 +0300
> Cc: emacs-devel@gnu.org
> From: Dmitry Gutov <dmitry@gutov.dev>
> 
> On 25/07/2023 17:05, Eli Zaretskii wrote:
> >> From: Andrew Tropin<andrew@trop.in>
> >> Cc:emacs-devel@gnu.org
> >> Date: Tue, 25 Jul 2023 17:41:27 +0400
> >>
> >>> On 25/07/2023 15:01, Eli Zaretskii wrote:
> >>>> But that's exactly the point: how can we make sure the file is "in
> >>>> cwd"?
> >>> When it's not in cwd, wouldn't (expand-file-name file) fail to work too?
> >> Right.
> >>
> >> Eli, by cwd I mean default-directory.
> > If that's what you meant, then my question should be rephrased: how do
> > we know that the code in question always runs when the buffer that is
> > the current buffer has the directory of the icon file as its
> > default-directory?
> 
> If it does not, then the current code is already wrong, isn't it?

No, it could be working by sheer luck.