Re: [PATCH] notifications: Don't expand-file-name app-icon.

[Michael Albinus]

Eli Zaretskii <eliz@gnu.org> writes:

>> >>>> But that's exactly the point: how can we make sure the file is "in
>> >>>> cwd"?
>> >>> When it's not in cwd, wouldn't (expand-file-name file) fail to work too?
>> >> Right.
>> >>
>> >> Eli, by cwd I mean default-directory.
>> > If that's what you meant, then my question should be rephrased: how do
>> > we know that the code in question always runs when the buffer that is
>> > the current buffer has the directory of the icon file as its
>> > default-directory?
>>
>> If it does not, then the current code is already wrong, isn't it?
>
> No, it could be working by sheer luck.

As always with relative file names: the caller is responsible to use a
proper default-directory. What else?

Btw, the relative file name could even be something like
"hicolor/scalable/mimetypes/emacs-document.svg", when default directory
is Emacs' ".../etc/images/icons/". Another argument for expanding the
:app-icon string.

Best regards, Michael.