[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] notifications: Don't expand-file-name app-icon.

From: Matthias Meulien
Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon.
Date: Wed, 26 Jul 2023 14:36:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: dmitry@gutov.dev,  andrew@trop.in,  emacs-devel@gnu.org
>> Date: Wed, 26 Jul 2023 09:05:04 +0200
>> Eli Zaretskii <eliz@gnu.org> writes:
>> >> As always with relative file names: the caller is responsible to use a
>> >> proper default-directory. What else?
>> >
>> > Wait a minute.  The icon's file is not processed by Emacs, right?  We
>> > pass it to an external program/library/service, right?
>> We pass it to an external service via a D-Bus call.
> In that case, we _definitely_ must call expand-file-name, and using
> relative file names without that is asking for trouble.

Why not try to be compliant with the called API?  According to the
Desktop Notification specification the Notify method support image path
being file URIs or in a freedesktop.org-compliant icon theme (see

Being able to specify an icon with its name name according to Icon
Naming Specification (see
is useful since file path vary depending on the OS!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]