[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] notifications: Don't expand-file-name app-icon.

From: Michael Albinus
Subject: Re: [PATCH] notifications: Don't expand-file-name app-icon.
Date: Wed, 26 Jul 2023 15:14:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Matthias Meulien <orontee@gmail.com> writes:

Hi Matthias,

>> In that case, we _definitely_ must call expand-file-name, and using
>> relative file names without that is asking for trouble.
> Why not try to be compliant with the called API?  According to the
> Desktop Notification specification the Notify method support image path
> being file URIs or in a freedesktop.org-compliant icon theme (see
> https://specifications.freedesktop.org/notification-spec/notification-spec-latest.html#icons-and-images).

Sending an image_path instead of app_icon as file:/// URL is just an
implementation detail. The `notifications-notify' API supports
the :image-path argument if users are willing to use it.

:app-icon can still be either a file name or an icon name. We must
distinguish relative file names from image names; that's what this
thread is about. Alternatively, we could allow only icon names with the
:app-icon argument, but this wouldn't be backward compatible.

> Being able to specify an icon with its name name according to Icon
> Naming Specification (see
> https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html)
> is useful since file path vary depending on the OS!

This is not true for relative file names.

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]