emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Improve find-sibling-rules option type


From: Mauro Aranda
Subject: Re: [PATCH v3] Improve find-sibling-rules option type
Date: Tue, 3 Oct 2023 07:27:38 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1

On 2/10/23 01:54, Paul W. Rankin via Emacs development discussions. wrote:
> * lisp/files.el (find-sibling-rules): use alist with tags for custom
>    type
> ---
> v3, make alist value a repeating string type.
>
>
>   lisp/files.el | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/files.el b/lisp/files.el
> index 9d76668..eceed75 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -7572,7 +7572,8 @@ find-sibling-rules
>   In this example, if you're in \"src/emacs/emacs-27/lisp/abbrev.el\",
>   and a \"src/emacs/emacs-28/lisp/abbrev.el\" file exists, it's now
>   defined as a sibling."
> -  :type 'sexp
> +  :type '(alist :key-type (regexp :tag "Match")
> +                :value-type (repeat (string :tag "Expansion")))
>     :version "29.1")
>
>   (defun find-sibling-file (file)

FWIW, the change looks good to me.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]