Re: [ELPA] New package: dired-duplicates

[Michael Heerdegen]

Harald Judt <h.judt@gmx.at> writes:

> > diff --git a/dired-duplicates.el b/dired-duplicates.el
> > index d62af02..4af37a3 100644
> > --- a/dired-duplicates.el
> > +++ b/dired-duplicates.el
> > @@ -54,7 +54,6 @@
> >   (defcustom dired-duplicates-separate-results
> >     t
> >     "Boolean value indicating whether to separate results with new-lines."
> > -  :group 'dired-duplicates
>
> [...]
>
> Why should I not use :group for customization? I thought this makes it
> easier to explore customization?

It's redundant - see (info "(elisp) Variable Definitions"):

     If a ‘defcustom’ does not specify any ‘:group’, the last group
     defined with ‘defgroup’ in the same file will be used.  This way,
     most ‘defcustom’ do not need an explicit ‘:group’.

If :group is specified, it will most of the time mean the defcustom should
be assigned to some other, not to the default, group.  So it's better
style to not explicitly specify the default.

Michael.