Re: master 048e72a403e 1/2: Add file/buffer-to-register (Bug#73308)

[Eshel Yaron]

Hi,

Barra Ó Catháin <barra@ocathain.ie> writes:

> D'oh! You're absolutely correct. I've attached a patch containing a fix
> for exactly this; adds a check to see if buffer is currently alive,
> and uses with-current-buffer to ensure that it's adding to the correct
> one.

Thanks!  I've applied your patch (with a minor tweak to the commit
message) in commit c0f10fc3d48.  I then followed up with a couple of
small refinements in commit 6a272dedad3It.  I mostly improved the
docstring and the minibuffer prompts, but note that I removed the
(let ((buffer (or (get-buffer buffer) buffer))) ...) binding: it only
has any effect if BUFFER is a string, which it isn't, it's a buffer.
Let me know if I misread something.

> Let me know if I should send this somewhere else; I'm still
> learning mailing list development etiquette.

This is fine for such a follow up, I think.


Best,

Eshel