Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer

[Jim Porter]

On 10/13/2024 6:06 PM, Sebastián Monía wrote:
> Attached a new patch that used vtable, and also adds the
> (eww-buffer-list) function that Jim mentioned before.
> Once this one is merged (after review & corrections :) etc.) I can take
> the same vtable approach for eww-bookmarks.

Thanks for the updated patch. Aside from the things Adam has already 
mentioned, this looks good to me. Just one small comment:

> +(defun eww--list-buffers-display-table (&optional ignore-auto noconfirm)
> +  "Display a table with the list of eww buffers.
> +Will remove all buffer contents first.  The parameters IGNORE-AUTO and
> +NOCONFIRM are ignored, they are for compatibility with
> +`revert-buffer-function'."
> +  (let ((inhibit-read-only t))
> +    (erase-buffer)
> +    (make-vtable
> +     :columns '((:name "Title" :width 30)

Maybe something like ':min-width "25%" :max-width "50%"' here? That way 
users can see longish page titles, and if all the titles are short, we 
give most of the space to the URLs.

(As an aside, I wonder how hard it would be to add support for 
'auto-revert-mode' to the EWW buffer list.)