emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reloa


From: Sebastián Monía
Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer
Date: Mon, 14 Oct 2024 00:06:39 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

Hello!

Adam Porter <adam@alphapapa.net> writes:
> Small suggestion: When possible, using BUFFER-LOCAL-VALUE is
> preferable over WITH-CURRENT-BUFFER, as it's significantly faster (in
> my testing). You could do this in `eww--list-buffers-get-data'.
>
> Also, you might want to disable the undo list in the list buffer to
> save memory, since there's no need to undo in that buffer.
>
> Finally, in `eww-buffer-list', you could use `match-buffers' instead
> of a bespoke loop.
>
> Thanks for working on this.
>
> --Adam

First, thank you, as I wasn't aware of buffer-local-value nor
match-buffers!

These sound a bit like micro-optimizations, how many eww buffers can one
person have open that these speed differences would matter?

And yes, I know "who would do that" is a dangerous question to ask in
the Emacs world :)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]