emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reloa


From: Adam Porter
Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer
Date: Mon, 14 Oct 2024 19:08:03 -0500
User-agent: Mozilla Thunderbird

On 10/13/24 23:06, Sebastián Monía wrote:

Hello!

Adam Porter <adam@alphapapa.net> writes:
Small suggestion: When possible, using BUFFER-LOCAL-VALUE is
preferable over WITH-CURRENT-BUFFER, as it's significantly faster (in
my testing). You could do this in `eww--list-buffers-get-data'.

Also, you might want to disable the undo list in the list buffer to
save memory, since there's no need to undo in that buffer.

Finally, in `eww-buffer-list', you could use `match-buffers' instead
of a bespoke loop.

Thanks for working on this.

--Adam

First, thank you, as I wasn't aware of buffer-local-value nor
match-buffers!

These sound a bit like micro-optimizations, how many eww buffers can one
person have open that these speed differences would matter?

I'm sure that the difference would not be noticeable. But when committing new code, why not choose the most efficient implementation, when the size and complexity of the source code is equivalent? Over 30 or 40 years, little things add up.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]