Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer

[Sebastián Monía]

Hello!


Jim Porter <jporterbugs@gmail.com> writes:
> Thanks for the updated patch. Aside from the things Adam has already
> mentioned

I added his suggestions in this patch.

>> +     :columns '((:name "Title" :width 30)>
> Maybe something like ':min-width "25%" :max-width "50%"' here? That
> way users can see longish page titles, and if all the titles are
> short, we give most of the space to the URLs.

Added in this patch too.

> (As an aside, I wonder how hard it would be to add support for
> 'auto-revert-mode' to the EWW buffer list.)

I was looking into it, we "just" need a good 'buffer-stale-function'.
All I could think of was to store the list used to populate the vtable
in a buffer-local variable, and check if the list has changed?

In an earlier version I used a variable to store the vtable data, but
moved to ':objects-function' because of the default binding for "g" in
vtables.

0001-Use-vtable-in-eww-list-buffers-add-function-eww-buff.patch
Description: patch with feedback addressed