Re: bookmark+: legacy key syntax in Emacs 30?

[Robert Pluim]

>>>>> On Wed, 16 Oct 2024 11:59:27 -0800, Christopher Howard 
>>>>> <christopher@librehacker.com> said:

    Christopher> I downloaded the latest files from the wiki but am still 
getting the same error when I require 'bookmark+.
    Christopher> I do not know much about keymaps at this point, but the 
offending line is in bookmark+-key.el:

    Christopher> ``` elisp
    Christopher> (define-key ctl-x-map "rK" 'bmkp-set-desktop-bookmark)        
; `C-x r K' (also `C-x x K', `C-x x c K')
    Christopher> ```

    Christopher> I see in the Emacs 30 documentation at least that define-key is
    Christopher> considered now a legacy function, and `keymap-set' is 
recommended
    Christopher> instead. Perhaps something broke in define-key from 29->30, so 
that it
    Christopher> no longer recognizes correctly the legacy string syntax?

Thatʼs possible, but in this case I canʼt reproduce your error. That
syntax is perfectly legal, and will remain so.

    Christopher> I'm CC'ing emacs-devel in hopes that an SME will weigh in on 
this.

Does this happen when you byte-compile the bookmark+ files? Or only
when you use the .el files?


Robert
--