emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 6084c7e: checkdoc: Only look for commonly used modifier keys


From: Stefan Kangas
Subject: master 6084c7e: checkdoc: Only look for commonly used modifier keys
Date: Sat, 18 Sep 2021 04:44:43 -0400 (EDT)

branch: master
commit 6084c7e0f401b5a68836ebc305c14b9a0feb3c43
Author: Stefan Kangas <stefan@marxist.se>
Commit: Stefan Kangas <stefan@marxist.se>

    checkdoc: Only look for commonly used modifier keys
    
    * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
    Search for the modifier key "s-", but not the modifier key "A-".
    The latter is very uncommon and leads to false positives.
---
 lisp/emacs-lisp/checkdoc.el | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/checkdoc.el b/lisp/emacs-lisp/checkdoc.el
index f8df223..2c30815 100644
--- a/lisp/emacs-lisp/checkdoc.el
+++ b/lisp/emacs-lisp/checkdoc.el
@@ -1545,7 +1545,9 @@ may require more formatting")
      ;;     Instead, use the `\\[...]' construct to stand for them.
      (save-excursion
        (let ((f nil) (m nil) (start (point))
-            (re "[^`‘A-Za-z0-9_]\\([CMA]-[a-zA-Z]\\|\\(\\([CMA]-\\)?\
+             ;; Ignore the "A-" modifier: it is uncommon in practice,
+             ;; and leads to false positives in regexp ranges.
+             (re "[^`‘A-Za-z0-9_]\\([CMs]-[a-zA-Z]\\|\\(\\([CMs]-\\)?\
 mouse-[0-3]\\)\\)\\>"))
         ;; Find the first key sequence not in a sample
         (while (and (not f) (setq m (re-search-forward re e t)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]