master bb3a045: Improve error messaging from byte-compiling dotted lists

[Lars Ingebrigtsen]

branch: master
commit bb3a045501281f7aafe800f729c253688780fc48
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Improve error messaging from byte-compiling dotted lists
    
    * lisp/emacs-lisp/cconv.el (cconv-analyze-form): Improve error
    messaging when byte-compiling dotted lists (bug#35186).
    
    Test case -- byte-compile the following file:
    
    ;;;  -*- lexical-binding: t -*-
    
    (defun foo ()
      (+ 1 2)
      (a . b))
---
 lisp/emacs-lisp/cconv.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el
index ba29e4e..0a6b04b 100644
--- a/lisp/emacs-lisp/cconv.el
+++ b/lisp/emacs-lisp/cconv.el
@@ -794,6 +794,8 @@ This function does not return anything but instead fills the
     ;; (`(declare . ,_) nil)               ;The args don't contain code.
 
     (`(,_ . ,body-forms)    ; First element is a function or whatever.
+     (unless (listp body-forms)
+       (signal 'wrong-type-argument (list 'proper-list-p form)))
      (dolist (form body-forms) (cconv-analyze-form form env)))
 
     ((pred symbolp)