emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 2b50dbb1a5: Remove bogus mode check from gnus topic update functi


From: Eric Abrahamsen
Subject: master 2b50dbb1a5: Remove bogus mode check from gnus topic update functions
Date: Wed, 4 May 2022 15:55:49 -0400 (EDT)

branch: master
commit 2b50dbb1a51054f8b6b1214db9dd0a69dd342c93
Author: Eric Abrahamsen <eric@ericabrahamsen.net>
Commit: Eric Abrahamsen <eric@ericabrahamsen.net>

    Remove bogus mode check from gnus topic update functions
    
    * lisp/gnus/gnus-topic.el (gnus-topic-update-topics-containing-group):
    (gnus-topic-update-topic): These functions originally checked to see
    if we were in group mode, but later that check was changed to
    'gnus-topic-mode, which never passes because 'gnus-topic-mode isn't a
    major mode. Revert to checking for 'gnus-group-mode, and use
    `derived-mode-p' while we're at it.
---
 lisp/gnus/gnus-topic.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/gnus/gnus-topic.el b/lisp/gnus/gnus-topic.el
index 479bba3a73..36b97acec8 100644
--- a/lisp/gnus/gnus-topic.el
+++ b/lisp/gnus/gnus-topic.el
@@ -678,7 +678,7 @@ articles in the topic and its subtopics."
 
 (defun gnus-topic-update-topics-containing-group (group)
   "Update all topics that have GROUP as a member."
-  (when (and (eq major-mode 'gnus-topic-mode)
+  (when (and (derived-mode-p 'gnus-group-mode)
             gnus-topic-mode)
     (save-excursion
       (let ((alist gnus-topic-alist))
@@ -694,7 +694,7 @@ articles in the topic and its subtopics."
 
 (defun gnus-topic-update-topic ()
   "Update all parent topics to the current group."
-  (when (and (eq major-mode 'gnus-topic-mode)
+  (when (and (derived-mode-p 'gnus-group-mode)
             gnus-topic-mode)
     (let ((group (gnus-group-group-name))
          (m (point-marker))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]