emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 42d740fb2c: ; Skip two eglot tests when typescript is missing


From: Stefan Kangas
Subject: emacs-29 42d740fb2c: ; Skip two eglot tests when typescript is missing
Date: Mon, 12 Dec 2022 11:54:34 -0500 (EST)

branch: emacs-29
commit 42d740fb2cb25eef26a5d2e3cab86fa38f909652
Author: Stefan Kangas <stefankangas@gmail.com>
Commit: Stefan Kangas <stefankangas@gmail.com>

    ; Skip two eglot tests when typescript is missing
    
    * test/lisp/progmodes/eglot-tests.el
    (javascript-basic, project-wide-diagnostics-typescript): Skip tests
    when the npm package "typescript" is not installed.
---
 test/lisp/progmodes/eglot-tests.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/lisp/progmodes/eglot-tests.el 
b/test/lisp/progmodes/eglot-tests.el
index fd0a68973e..32eefd778f 100644
--- a/test/lisp/progmodes/eglot-tests.el
+++ b/test/lisp/progmodes/eglot-tests.el
@@ -723,7 +723,8 @@ pylsp prefers autopep over yafp, despite its README stating 
the contrary."
 
 (ert-deftest javascript-basic ()
   "Test basic autocompletion in a JavaScript LSP."
-  (skip-unless (executable-find "typescript-language-server"))
+  (skip-unless (and (executable-find "typescript-language-server")
+                    (executable-find "tsserver")))
   (eglot--with-fixture
       '(("project" . (("hello.js" . "console.log('Hello world!');"))))
     (with-current-buffer
@@ -752,7 +753,8 @@ pylsp prefers autopep over yafp, despite its README stating 
the contrary."
 
 (ert-deftest project-wide-diagnostics-typescript ()
   "Test diagnostics through multiple files in a TypeScript LSP."
-  (skip-unless (executable-find "typescript-language-server"))
+  (skip-unless (and (executable-find "typescript-language-server")
+                    (executable-find "tsserver")))
   (eglot--with-fixture
       '(("project" . (("hello.ts" . "const thing = 5;\nexport { thin }")
                       ("hello2.ts" . "import { thing } from './hello'"))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]