emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 a0806bc7ea 1/2: Eglot: fix discrepant eglot-guess-contact/eglot


From: João Távora
Subject: emacs-29 a0806bc7ea 1/2: Eglot: fix discrepant eglot-guess-contact/eglot-command-history
Date: Fri, 16 Dec 2022 04:28:47 -0500 (EST)

branch: emacs-29
commit a0806bc7ea916bff49ecb452716c01d42307aec9
Author: João Távora <joaotavora@gmail.com>
Commit: João Távora <joaotavora@gmail.com>

    Eglot: fix discrepant eglot-guess-contact/eglot-command-history
    
    Due to a typo, the defvar eglot--command-history wasn't actually used
    in eglot-guess-contact as intended.  That function used a
    single-dash-name version of the variable instead.
    
    This worked fine, except that two variables were created instead of
    one, and the one actually being used didn't have any docstring.
    
    Rename the variable to eglot-command-history to fix this.  It's better
    than renaming the reference in eglot-guess-contact which would lose
    user's history for M-x eglot.
    
    * lisp/progmodes/eglot.el (eglot-command-history): Rename from
    eglot--command-history.
---
 lisp/progmodes/eglot.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index bb07a06dde..d4d04b1bc4 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -941,7 +941,7 @@ PRESERVE-BUFFERS as in `eglot-shutdown', which see."
                   (push sym retval))))
     retval))
 
-(defvar eglot--command-history nil
+(defvar eglot-command-history nil
   "History of CONTACT arguments to `eglot'.")
 
 (defun eglot--lookup-mode (mode)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]