[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
emacs-29 45b16bfb496: Skip failing tests on Cygwin with native compilati
From: |
Ken Brown |
Subject: |
emacs-29 45b16bfb496: Skip failing tests on Cygwin with native compilation (bug#62450) |
Date: |
Sun, 26 Mar 2023 10:05:28 -0400 (EDT) |
branch: emacs-29
commit 45b16bfb496025d9f21f7cdccb6a25a0be83a26f
Author: Ken Brown <kbrown@cornell.edu>
Commit: Ken Brown <kbrown@cornell.edu>
Skip failing tests on Cygwin with native compilation (bug#62450)
* test/Makefile.in (TEST_NATIVE_COMP): New variable, used to
determine whether to run tests tagged with :nativecomp. Set it to
"no" on Cygwin and to $(HAVE_NATIVE_COMP) otherwise.
* test/lisp/emacs-lisp/benchmark-tests.el (benchmark-tests): Skip
on Cygwin with native-compilation.
---
test/Makefile.in | 9 ++++++++-
test/lisp/emacs-lisp/benchmark-tests.el | 4 ++++
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/test/Makefile.in b/test/Makefile.in
index fd21695f5bc..e8edf7739b7 100644
--- a/test/Makefile.in
+++ b/test/Makefile.in
@@ -124,7 +124,14 @@ test_module_dir := src/emacs-module-resources
all: check
-ifeq ($(HAVE_NATIVE_COMP),yes)
+SYSTEM_TYPE = @SYSTEM_TYPE@
+TEST_NATIVE_COMP = $(HAVE_NATIVE_COMP)
+# Avoid fork failures on Cygwin. See bug#62450 and etc/PROBLEMS
+# ("Fork failures in a build with native compilation").
+ifeq ($(SYSTEM_TYPE),cygwin)
+TEST_NATIVE_COMP = no
+endif
+ifeq ($(TEST_NATIVE_COMP),yes)
SELECTOR_DEFAULT = (not (or (tag :expensive-test) (tag :unstable)))
SELECTOR_EXPENSIVE = (not (tag :unstable))
SELECTOR_ALL = t
diff --git a/test/lisp/emacs-lisp/benchmark-tests.el
b/test/lisp/emacs-lisp/benchmark-tests.el
index 31357f24a0d..99b5b142c37 100644
--- a/test/lisp/emacs-lisp/benchmark-tests.el
+++ b/test/lisp/emacs-lisp/benchmark-tests.el
@@ -23,6 +23,10 @@
(require 'ert)
(ert-deftest benchmark-tests ()
+ ;; Avoid fork failures on Cygwin. See bug#62450 and etc/PROBLEMS
+ ;; ("Fork failures in a build with native compilation").
+ (skip-unless (not (and (eq system-type 'cygwin)
+ (featurep 'native-compile))))
(let (str t-long t-short m)
(should (consp (benchmark-run nil (setq m (1+ 0)))))
(should (consp (benchmark-run 1 (setq m (1+ 0)))))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- emacs-29 45b16bfb496: Skip failing tests on Cygwin with native compilation (bug#62450),
Ken Brown <=