[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/kiwix 3b73980 12/13: Add Emacs built-in completing-read
From: |
Stefan Monnier |
Subject: |
[elpa] externals/kiwix 3b73980 12/13: Add Emacs built-in completing-read support |
Date: |
Mon, 4 Jan 2021 01:12:53 -0500 (EST) |
branch: externals/kiwix
commit 3b73980bea4a81002174966262a1efeac4dd7593
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: stardiviner <numbchild@gmail.com>
Add Emacs built-in completing-read support
---
kiwix.el | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/kiwix.el b/kiwix.el
index f73dfd3..91ee4e5 100644
--- a/kiwix.el
+++ b/kiwix.el
@@ -120,9 +120,11 @@
:safe #'stringp)
(defcustom kiwix-default-completing-read (cond ((fboundp 'ivy-read) 'ivy)
- ((fboundp 'helm) 'helm))
+ ((fboundp 'helm) 'helm)
+ (t t))
"Kiwix default completion frontend.
-Currently Ivy (`ivy') and Helm (`helm') both supported."
+Currently Ivy (`ivy') and Helm (`helm') both supported.
+Set it to ‘t’ will use Emacs built-in ‘completing-read’."
:type 'symbol
:safe #'symbolp)
@@ -323,7 +325,17 @@ list and return a list result."
:update-fn 'auto
:sort t
:dynamic-collection t
- :caller 'ivy-done)))))
+ :caller 'ivy-done))
+ (_
+ (completing-read
+ "Kiwix related entries: "
+ ;; FIXME: This needs work!
+ (completion-table-dynamic
+ (lambda (input)
+ (apply #'kiwix-ajax-search-hints
+ input `(,kiwix--selected-library))))
+ nil nil
+ (kiwix--get-thing-at-point))))))
(message (format "library: %s, query: %s" library query))
(if (or (null library)
(string-empty-p library)
- [elpa] externals/kiwix updated (9ab1437 -> 4f987d4), Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 6bf78fb 02/13: improve kiwix-server-command custom option, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix aa97754 01/13: use-package :commands is not needed, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 8100281 04/13: highlight ivy and helm symbols in docstring, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 2e242cb 03/13: follow GNU convention rename "path" to "dir", Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix feb09b6 06/13: Fix directory files matching regexp, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 5356b31 09/13: Fix docker pull command's if logic, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 4f987d4 13/13: Disable GitHub Actions MELPA strict checker, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix a68a7f5 05/13: Fix commentary indent level, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 3b73980 12/13: Add Emacs built-in completing-read support,
Stefan Monnier <=
- [elpa] externals/kiwix 4110223 08/13: Explain function kiwix-server-url-update docstring, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix feda7b8 11/13: Fix use region detection, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 05fdb07 07/13: Replace async-shell-command with start-process in kiwix-launch-server, Stefan Monnier, 2021/01/04
- [elpa] externals/kiwix 26a796c 10/13: Use and or logic maybe faster?, Stefan Monnier, 2021/01/04