[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/embark e6a991c322 5/9: Let's not be embarrased about ad
From: |
ELPA Syncer |
Subject: |
[elpa] externals/embark e6a991c322 5/9: Let's not be embarrased about advising an internal Embark function |
Date: |
Mon, 2 May 2022 09:57:32 -0400 (EDT) |
branch: externals/embark
commit e6a991c32215e538bd2778f662c63d8fa58245cc
Author: Omar Antolín <omar.antolin@gmail.com>
Commit: Omar Antolín <omar.antolin@gmail.com>
Let's not be embarrased about advising an internal Embark function
---
embark-consult.el | 2 --
1 file changed, 2 deletions(-)
diff --git a/embark-consult.el b/embark-consult.el
index 898cde0281..72cb479f1a 100644
--- a/embark-consult.el
+++ b/embark-consult.el
@@ -395,8 +395,6 @@ Meant as :after-until advice for
`embark-collect--metadatum'."
(transform cand)
(type (car (alist-get type config))))))))
-;; TODO can we find a better solution than the advice here?
-;; Can we hook more directly into `embark-collect--metadatum'?
(advice-add #'embark-collect--metadatum :after-until
#'embark-consult--imenu-group-function)
- [elpa] externals/embark updated (7a2487f5bb -> a8bc5d602d), ELPA Syncer, 2022/05/02
- [elpa] externals/embark a26044888e 1/9: Fix doc string warnings, ELPA Syncer, 2022/05/02
- [elpa] externals/embark a3f418154d 3/9: Use a more localized advice only for embark-collect--metadatum, ELPA Syncer, 2022/05/02
- [elpa] externals/embark 25217ccddf 2/9: outline-minor-mode is autoloaded, ELPA Syncer, 2022/05/02
- [elpa] externals/embark 2d017739a0 4/9: Remap paragraph commands to outline heading commands, ELPA Syncer, 2022/05/02
- [elpa] externals/embark e6a991c322 5/9: Let's not be embarrased about advising an internal Embark function,
ELPA Syncer <=
- [elpa] externals/embark 4f2770a4b3 7/9: Merge pull request #498 from minad/outline-review, ELPA Syncer, 2022/05/02
- [elpa] externals/embark a3e2a186ec 8/9: Make the group title format configurable (fix #497), ELPA Syncer, 2022/05/02
- [elpa] externals/embark a8bc5d602d 9/9: Make the collect group headers normal-sized, ELPA Syncer, 2022/05/02
- [elpa] externals/embark fa0ef92a96 6/9: Add {, } for outline navigation in collect buffers, ELPA Syncer, 2022/05/02