emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/git-commit f331092df4: magit-revert-rev-file-buffer: Use d


From: ELPA Syncer
Subject: [nongnu] elpa/git-commit f331092df4: magit-revert-rev-file-buffer: Use delay-mode-hook
Date: Sun, 8 May 2022 14:58:13 -0400 (EDT)

branch: elpa/git-commit
commit f331092df4d4dfc0a2a7424d929a9c845088d57f
Author: Ellis Kenyo <me@elken.dev>
Commit: Jonas Bernoulli <jonas@bernoul.li>

    magit-revert-rev-file-buffer: Use delay-mode-hook
    
    For that newly-opened buffer to have syntax coloring this function
    briefly sets buffer-file-name and performs (normal-mode t).  This,
    in turn, triggers related major-mode hooks, which at least in the
    case of lsp causes issues.
    
    Also discussed in https://github.com/doomemacs/doomemacs/pull/6309.
---
 lisp/magit-files.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/magit-files.el b/lisp/magit-files.el
index 2660898d78..c1a150fd2b 100644
--- a/lisp/magit-files.el
+++ b/lisp/magit-files.el
@@ -179,7 +179,8 @@ then only after asking.  A non-nil value for REVERT is 
ignored if REV is
           (after-change-major-mode-hook
            (remq 'global-diff-hl-mode-enable-in-buffers
                  after-change-major-mode-hook)))
-      (normal-mode t))
+      (delay-mode-hooks
+        (normal-mode t)))
     (setq buffer-read-only t)
     (set-buffer-modified-p nil)
     (goto-char (point-min))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]