emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/plz 87007fc612 57/81: Add: FIXMEs


From: ELPA Syncer
Subject: [elpa] externals/plz 87007fc612 57/81: Add: FIXMEs
Date: Wed, 11 May 2022 17:58:02 -0400 (EDT)

branch: externals/plz
commit 87007fc61205ad82dc07e5fe3b8c4c6acfdaa4bb
Author: Adam Porter <adam@alphapapa.net>
Commit: Adam Porter <adam@alphapapa.net>

    Add: FIXMEs
---
 plz.el            | 1 +
 tests/test-plz.el | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/plz.el b/plz.el
index e768deeadb..06ba565564 100644
--- a/plz.el
+++ b/plz.el
@@ -495,6 +495,7 @@ node `(elisp) Sentinels').  Kills the buffer before 
returning."
                     (curl-error-message (alist-get curl-exit-code 
plz-curl-errors))
                     (err (make-plz-error :curl-error (cons curl-exit-code 
curl-error-message))))
                (pcase-exhaustive plz-else
+                 ;; FIXME: Returning a plz-error struct which has a curl-error 
slot, wrapped in a plz-curl-error, is confusing.
                  (`nil (signal 'plz-curl-error err))
                  ((pred functionp) (funcall plz-else err)))))
 
diff --git a/tests/test-plz.el b/tests/test-plz.el
index 12e2c44456..37e8bad697 100644
--- a/tests/test-plz.el
+++ b/tests/test-plz.el
@@ -220,6 +220,8 @@
                    (plz-error-curl-error (cdr err))))))
 
 (ert-deftest plz-get-404-error nil
+  ;; FIXME: Wrap each test expression in `should' rather than using 
`should-and'.
+
   ;; Async.
   (let* ((err)
          (process (plz 'get "https://httpbin.org/get/status/404";



reply via email to

[Prev in Thread] Current Thread [Next in Thread]