emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/helm 56c2230d03: Revert partially 1b1f1ed9 for helm-eval a


From: ELPA Syncer
Subject: [nongnu] elpa/helm 56c2230d03: Revert partially 1b1f1ed9 for helm-eval as the feature IS working
Date: Mon, 1 Aug 2022 12:58:51 -0400 (EDT)

branch: elpa/helm
commit 56c2230d03c27ee1c97d633ab6bbe95abaf76ccb
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Revert partially 1b1f1ed9 for helm-eval as the feature IS working
    
    in emacs-27. Emacs-28+ is more restrictive and works only if
    minibuffer-follows-selected-frame is indeed deactivated.
    See window-deletable-p which should return 'frame in such case.
---
 helm-eval.el | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/helm-eval.el b/helm-eval.el
index 33a8744ec9..72b7884bf5 100644
--- a/helm-eval.el
+++ b/helm-eval.el
@@ -180,12 +180,7 @@ Should take one arg: the string to display."
 (defun helm-eval-expression (arg)
   "Preconfigured `helm' for `helm-source-evaluation-result'."
   (interactive "P")
-  (let ((helm-elisp-help-function #'helm-elisp-show-doc-modeline)
-        (helm-show-completion-display-function
-         ;; Nested completion in a frame works only in emacs-28+ when
-         ;; minibuffer-follows-selected-frame is available.
-         (and (boundp 'minibuffer-follows-selected-frame)
-              (default-value 'helm-show-completion-display-function))))
+  (let ((helm-elisp-help-function #'helm-elisp-show-doc-modeline))
     (helm :sources (helm-build-evaluation-result-source)
           :input (when arg (thing-at-point 'sexp))
           :buffer "*helm eval*"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]