[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/denote 16e67cba93 4/4: Clarify TODO about denote--only-
From: |
ELPA Syncer |
Subject: |
[elpa] externals/denote 16e67cba93 4/4: Clarify TODO about denote--only-note-p |
Date: |
Thu, 11 Aug 2022 22:57:29 -0400 (EDT) |
branch: externals/denote
commit 16e67cba93ee0beec3758e4c3901af8573d3c6ca
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Clarify TODO about denote--only-note-p
---
denote.el | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/denote.el b/denote.el
index 570e52fa0b..cb7b27a779 100644
--- a/denote.el
+++ b/denote.el
@@ -427,7 +427,12 @@ trailing hyphen."
;; TODO 2022-08-11: In light of `denote--writable-and-supported-p', we
;; should either harden `denote--only-note-p' to also check for a
-;; `denote-directory' or decide how to merge the two functions.
+;; `denote-directory' or decide how to merge the two functions. I think
+;; hardening this one is more appropriate.
+;;
+;; There are two different needs:
+;; - When converting a file to Denote, we need relaxed conditionality.
+;; = When we truly need a "note", we have to be more strict.
(defun denote--only-note-p (file)
"Make sure FILE is an actual Denote note."
(let ((file-name (file-name-nondirectory file)))