emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote 91b626aa1c 3/6: Make links use denote--retrieve-


From: ELPA Syncer
Subject: [elpa] externals/denote 91b626aa1c 3/6: Make links use denote--retrieve-title-or-filename
Date: Mon, 15 Aug 2022 05:57:38 -0400 (EDT)

branch: externals/denote
commit 91b626aa1c1f0d89081060e34a807f1227fe7359
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Make links use denote--retrieve-title-or-filename
---
 denote.el | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/denote.el b/denote.el
index 2d46c8cd1c..a4b5c07dcd 100644
--- a/denote.el
+++ b/denote.el
@@ -1930,17 +1930,13 @@ title."
     ("md" denote-link--regexp-markdown)
     (_ denote-link--regexp-org)))
 
-;; FIXME 2022-08-13: Write this cleanly
 (defun denote-link--format-link (file pattern)
   "Prepare link to FILE using PATTERN."
-  (if (denote--writable-and-supported-p file)
-      (let* ((file-id (denote--retrieve-filename-identifier file))
-             (file-type (denote--filetype-heuristics file))
-             (file-title (unless (string= pattern denote-link--format-id-only)
-                           (denote--retrieve-title-value file file-type))))
-        (format pattern file-id file-title))
-    (format denote-link--format-id-only
-            (denote--retrieve-filename-identifier file))))
+  (let* ((file-id (denote--retrieve-filename-identifier file))
+         (file-type (denote--filetype-heuristics file))
+         (file-title (unless (string= pattern denote-link--format-id-only)
+                       (denote--retrieve-title-or-filename file file-type))))
+    (format pattern file-id file-title)))
 
 ;;;###autoload
 (defun denote-link (target &optional id-only)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]