emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/denote ada6348415 02/14: Remove TODO for denote--only-n


From: ELPA Syncer
Subject: [elpa] externals/denote ada6348415 02/14: Remove TODO for denote--only-note-p
Date: Mon, 15 Aug 2022 23:57:29 -0400 (EDT)

branch: externals/denote
commit ada63484151a31dda2ca7f0ecfd797c954585d19
Author: Jean-Philippe Gagné Guay <jeanphilippe150@gmail.com>
Commit: Jean-Philippe Gagné Guay <jeanphilippe150@gmail.com>

    Remove TODO for denote--only-note-p
---
 denote.el | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/denote.el b/denote.el
index 488bff7469..d9af89a652 100644
--- a/denote.el
+++ b/denote.el
@@ -426,14 +426,6 @@ trailing hyphen."
   "Return non-nil if FILE is empty."
   (zerop (or (file-attribute-size (file-attributes file)) 0)))
 
-;; TODO 2022-08-11: In light of `denote--writable-and-supported-p', we
-;; should either harden `denote--only-note-p' to also check for a
-;; `denote-directory' or decide how to merge the two functions.  I think
-;; hardening this one is more appropriate.
-;;
-;; There are two different needs:
-;; - When converting a file to Denote, we need relaxed conditionality.
-;; = When we truly need a  "note", we have to be more strict.
 (defun denote--only-note-p (file)
   "Make sure FILE is an actual Denote note."
   (let ((file-name (file-name-nondirectory file)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]