emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] externals/pulsar b7915dd060: Read real-this-command if necessary


From: ELPA Syncer
Subject: [elpa] externals/pulsar b7915dd060: Read real-this-command if necessary
Date: Fri, 19 Aug 2022 02:58:04 -0400 (EDT)

branch: externals/pulsar
commit b7915dd060818fed16578480f4181a0d566d487c
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>

    Read real-this-command if necessary
    
    The need for this arrangement became clear after trying to make the
    scroll motions of the 'evil' package work with pulsar-pulse-functions.
    
    Thanks to Duy Nguyen for reporting the issue on the mailing list.  I
    helped find the source of the apparent problem in the 'evil' code base
    and then Tom Dalziel explained why 'evil' does things this way,
    suggesting 'real-this-command' as a possibility:
    
    - 
<https://lists.sr.ht/~protesilaos/pulsar/%3C89566F5C-25AD-4281-94CB-031FE8878119%40gmail.com%3E>
    - 
<https://lists.sr.ht/~protesilaos/pulsar/%3C87pmgy3vzq.fsf%40protesilaos.com%3E>
    - <https://github.com/emacs-evil/evil/issues/1659>
---
 README.org | 4 ++--
 pulsar.el  | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/README.org b/README.org
index 8566601f9d..3456eab336 100644
--- a/README.org
+++ b/README.org
@@ -305,8 +305,8 @@ Pulsar is meant to be a collective effort.  Every bit of 
help matters.
 + Contributions to the code or manual :: Aymeric Agon-Rambosson, Daniel
   Mendler, Ivan Popovych, JD Smith.
 
-+ Ideas and user feedback :: Mark Barton, Petter Storvik, Rudolf
-  Adamkovič, Toon Claes, and users djl, kb.
++ Ideas and user feedback :: Duy Nguyen, Mark Barton, Petter Storvik,
+  Rudolf Adamkovič, Toon Claes, and users djl, kb.
 
 * GNU Free Documentation License
 :PROPERTIES:
diff --git a/pulsar.el b/pulsar.el
index ed62b86768..0e2506f663 100644
--- a/pulsar.el
+++ b/pulsar.el
@@ -393,7 +393,8 @@ This is a buffer-local mode.  Also check 
`pulsar-global-mode'."
 (defun pulsar--post-command-pulse ()
   "Run `pulsar-pulse-line' for `pulsar-pulse-functions'."
   (when (and (or pulsar-mode pulsar-global-mode)
-             (memq this-command pulsar-pulse-functions))
+             (or (memq this-command pulsar-pulse-functions)
+                 (memq real-this-command pulsar-pulse-functions)))
     (pulsar-pulse-line)))
 
 (make-obsolete 'pulsar-setup nil "0.3.0")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]