[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/topspace 3fa532a343 100/181: Fix terminal bug from PR #
From: |
ELPA Syncer |
Subject: |
[elpa] externals/topspace 3fa532a343 100/181: Fix terminal bug from PR #10 |
Date: |
Tue, 23 Aug 2022 12:58:38 -0400 (EDT) |
branch: externals/topspace
commit 3fa532a34324da2e3256d521bf8feca2183148ed
Author: Trevor Pogue <poguete@mcmaster.ca>
Commit: Trevor Pogue <poguete@mcmaster.ca>
Fix terminal bug from PR #10
- PR #10 introduced a bug where scrolling doesn't working as expected
when Emacs is run in terminal. The fix for this in the previous commit
was not sufficient. This commit fixes the source of the problem,
which was that floats were being passed to
scroll-up/scroll-down from the added advice functions, but that
seems to be invalid when in terminal. So now only integers are being
passed
to scroll-up/scroll-down when in terminal.
---
topspace.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/topspace.el b/topspace.el
index bee193ba24..cca8595623 100644
--- a/topspace.el
+++ b/topspace.el
@@ -209,7 +209,9 @@ TOTAL-LINES is used in the same way as in `scroll-down'."
(+ old-topspace-height total-lines)))
(setq topspace--window-start-before-scroll (window-start))
(topspace--draw new-topspace-height)
- (- total-lines (- new-topspace-height old-topspace-height))))
+ (setq total-lines
+ (- total-lines (- new-topspace-height old-topspace-height)))
+ (if (display-graphic-p) total-lines (round total-lines))))
(defun topspace--filter-args-scroll-down (&optional total-lines)
"Run before `scroll-down' for scrolling above the top line.
@@ -360,9 +362,7 @@ or if the selected window is in a child-frame."
(defun topspace--window-height ()
"Return the number of screen lines in the selected window rounded up."
- (if (display-graphic-p)
- (float (floor (window-screen-lines)))
- (floor (window-screen-lines))))
+ (float (floor (window-screen-lines))))
(defun topspace--count-pixel-height (start end)
"Return total pixels between points START and END as if they're both
visible."
- [elpa] externals/topspace 334fecd4c4 068/181: Update description in topspace.el and readme.md, (continued)
- [elpa] externals/topspace 334fecd4c4 068/181: Update description in topspace.el and readme.md, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace c1e4621a11 067/181: Update description in topspace.el and readme.md, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace ac2e2c2cdb 072/181: Mention to follow Elisp style guides, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace a0aa7b9b07 066/181: Remove checkdoc warnings, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace b305bb56be 078/181: Add HISTORY.md containing legacy changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 270b4ace51 069/181: Update changelog for v0.1.2, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 9d3125c0ec 081/181: Test automatic changelog generation action, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 45b44cf17c 084/181: Add automatic changelog generation action, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 8309cd98ab 096/181: Private refactoring & minor improvements, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace d4615f82f8 098/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 3fa532a343 100/181: Fix terminal bug from PR #10,
ELPA Syncer <=
- [elpa] externals/topspace 8fcd11d4a5 113/181: Fix mwheel mouse scrolling down bug causes by #11, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace c5b424788f 116/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 9760a3ab5e 123/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 2c8440f5de 124/181: Add support for `smooth-scrolling` package (#14), ELPA Syncer, 2022/08/23
- [elpa] externals/topspace d346f7b5e0 131/181: Update README.md, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 2f35223b78 132/181: Fix unexpected top space height change when echo area height changes (#18), ELPA Syncer, 2022/08/23
- [elpa] externals/topspace ca7eb6b94a 133/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 1bfa4d1b28 135/181: Update Changelog, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace e7df37fd99 139/181: Add section links to readme, ELPA Syncer, 2022/08/23
- [elpa] externals/topspace 15ac6c969a 141/181: Internal optimizations and refactoring, ELPA Syncer, 2022/08/23