[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] externals/ef-themes 5a98e7a420 2/4: Add support for completion gr
From: |
ELPA Syncer |
Subject: |
[elpa] externals/ef-themes 5a98e7a420 2/4: Add support for completion group titles |
Date: |
Sat, 27 Aug 2022 06:57:34 -0400 (EDT) |
branch: externals/ef-themes
commit 5a98e7a4206dfe2064c1f70a9c28e8eae10a0c3b
Author: Protesilaos Stavrou <info@protesilaos.com>
Commit: Protesilaos Stavrou <info@protesilaos.com>
Add support for completion group titles
These are headings which are used by various commands, such as
'consult-buffer', 'consult-imenu', and 'consult-grep'. As they denote a
group name, we apply the 'name' colour mapping. And since they are
titles, we inherit from 'bold' to make them look like headings.
We cannot use the default style of combining the 'shadow' and 'italic'
faces as the result is not sufficiently distinct from the main
foreground value for the purposes of the completion interfaces (whereas
that design is okay with the modus-themes).
For theme-wide consistency, also check 'compilation-info', which styles
file names in Grep and related buffers. Quote from commit ffb4cfb:
Decouple 'compilation-info' from 'success'
It made file names green in Grep and Xref buffers, which does not look
good in any theme. Using the "name" mapping gives us thematically
consistent results.
I inspected emacs.git to check if there is anything that uses
'compilation-info' to convey colour-coding along the lines of the
familiar red-green dichotomy, but could not find anything. As such, I
am treating this face in more flexible terms.
Thanks to Summer Emacs for the feedback which amounted to:
1. Treating group titles as headings (i.e. bold).
2. Using a more consistent colour.
[ Any mistakes are always my own. ]
---
ef-themes.el | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ef-themes.el b/ef-themes.el
index 5c5512f5ca..f4188813b6 100644
--- a/ef-themes.el
+++ b/ef-themes.el
@@ -666,6 +666,7 @@ Helper function for `ef-themes-preview-colors'."
`(completions-annotations ((,c :inherit italic :foreground ,docstring)))
`(completions-common-part ((,c :inherit bold :foreground ,accent-0)))
`(completions-first-difference ((,c :inherit bold :foreground ,accent-1)))
+ `(completions-group-title ((,c :inherit bold :foreground ,name)))
;;;; consult
`(consult-async-split ((,c :inherit warning)))
`(consult-key ((,c :inherit ef-themes-key-binding)))
@@ -814,6 +815,7 @@ Helper function for `ef-themes-preview-colors'."
`(embark-keybinding ((,c :inherit ef-themes-key-binding)))
`(embark-keybinding-repeat ((,c :inherit bold)))
`(embark-collect-marked ((,c :inherit success :background ,bg-info)))
+ `(embark-collect-group-title ((,c :inherit bold :foreground ,name)))
;;;; epa
`(epa-field-body (( )))
`(epa-field-name ((,c :inherit bold :foreground ,fg-dim)))
@@ -1419,6 +1421,7 @@ Helper function for `ef-themes-preview-colors'."
`(vc-up-to-date-state (( )))
;;;; vertico
`(vertico-current ((,c :background ,bg-completion)))
+ `(vertico-group-title ((,c :inherit bold :foreground ,name)))
;;;; wgrep
`(wgrep-delete-face ((,c :inherit warning)))
`(wgrep-done-face ((,c :background ,bg-info :foreground ,info)))