[nongnu] elpa/helm 7c448f6fc8 1/2: Comments only

[ELPA Syncer]

branch: elpa/helm
commit 7c448f6fc82516952972e2ed2ee12206f46cc0cb
Author: Thierry Volpiatto <thievol@posteo.net>
Commit: Thierry Volpiatto <thievol@posteo.net>

    Comments only
---
 helm-lib.el | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/helm-lib.el b/helm-lib.el
index 90b191a5d3..ff3561518e 100644
--- a/helm-lib.el
+++ b/helm-lib.el
@@ -296,6 +296,19 @@ available APPEND is ignored."
 ;; that no change to file is done.
 ;; This also lead to ask confirmation for every files even when not
 ;; modified and when `wdired-use-interactive-rename' is nil.
+;; Obviously, we could make an :around advice like this:
+;; (defun helm--advice-wdired-get-filename (old--fn &rest args)
+;;   (let* ((file  (apply old--fn args))
+;;          (split (and file (split-string file "//"))))
+;;     (if (and (cdr split)
+;;              (string-match (format "\\(%s/\\)\\1" (car split)) file))
+;;         (replace-match "" nil nil file 1)
+;;       file)))
+;; But for some reasons the original function in emacs-28 is returning
+;; nil in some conditions and operation fails with no errors but with
+;; something like "(no change performed)", so use an old version of
+;; `wdired-get-filename' with its output modified and advice it with
+;; :override.
 (defun helm--advice-wdired-get-filename (&optional no-dir old)
   ;; FIXME: Use dired-get-filename's new properties.
   (let (beg end file)